diff options
| author | Dan McGee <dan@archlinux.org> | 2011-02-04 09:15:22 -0600 |
|---|---|---|
| committer | Dan McGee <dan@archlinux.org> | 2011-02-04 09:15:22 -0600 |
| commit | 7664a58d4e95f0e1f1b433add61f3b658b926aaa (patch) | |
| tree | 7dd1952b590cc43d82f2034a489b43a244dadb0d | |
| parent | e34fc4eddf73f2453b42235f5ae7d65f75db66fc (diff) | |
| download | pacman-7664a58d4e95f0e1f1b433add61f3b658b926aaa.tar.gz pacman-7664a58d4e95f0e1f1b433add61f3b658b926aaa.zip | |
Add comment about download file resolution
Signed-off-by: Dan McGee <dan@archlinux.org>
| -rw-r--r-- | lib/libalpm/dload.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/lib/libalpm/dload.c b/lib/libalpm/dload.c index 15d75556..7a98eb12 100644 --- a/lib/libalpm/dload.c +++ b/lib/libalpm/dload.c @@ -172,6 +172,14 @@ static int download_internal(const char *url, const char *localpath, /* NOTE: libfetch does not reset the error code, be sure to do it before * calls into the library */ + /* TODO: if we call fetchStat() and get a redirect (disabling automagic + * redirect following), we should repeat the file locator stuff and get a new + * filename rather than only base if off the first URL, and then verify + * get_filename() didn't return ''. Of course, libfetch might not even allow + * us to even get that URL...FS#22645. This would allow us to download things + * without totally puking like + * http://www.archlinux.org/packages/community/x86_64/exim/download/ */ + /* find out the remote size *and* mtime in one go. there is a lot of * trouble in trying to do both size and "if-modified-since" logic in a * non-stat request, so avoid it. */ |