diff options
| author | Andrew Gregory <andrew.gregory.8@gmail.com> | 2017-05-10 18:54:54 -0400 |
|---|---|---|
| committer | Allan McRae <allan@archlinux.org> | 2017-05-16 12:39:39 +1000 |
| commit | a2b776f6c901c706946b49d2b5cadb0c6efd2655 (patch) | |
| tree | a3507efea3874c7b50b8a10cfc54faffee086e5f | |
| parent | 1bc79cb9a5067d685ba507fad9b189ed28ad70a0 (diff) | |
| download | pacman-a2b776f6c901c706946b49d2b5cadb0c6efd2655.tar.gz pacman-a2b776f6c901c706946b49d2b5cadb0c6efd2655.zip | |
query_fileowner: avoid buffer overflow
Copying a string into a buffer that has just been determined to not be
able to hold it is obviously incorrect. The actual error handling
appears to have been unintentionally removed in
47762ab687959e48acc2de8592fcf3ba3cfa502b.
Signed-off-by: Andrew Gregory <andrew.gregory.8@gmail.com>
Signed-off-by: Allan McRae <allan@archlinux.org>
| -rw-r--r-- | src/pacman/query.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/pacman/query.c b/src/pacman/query.c index a8417570..024d3e21 100644 --- a/src/pacman/query.c +++ b/src/pacman/query.c @@ -204,6 +204,7 @@ static int query_fileowner(alpm_list_t *targets) size_t rlen = strlen(rpath); if(rlen + 2 >= PATH_MAX) { pm_printf(ALPM_LOG_ERROR, _("path too long: %s/\n"), rpath); + goto targcleanup; } strcat(rpath + rlen, "/"); } |