From e8feaa3e01fdb326e82139ff80fce34f7e088438 Mon Sep 17 00:00:00 2001 From: Dan McGee Date: Tue, 7 Dec 2010 13:52:40 -0600 Subject: Save DB query when filtering dependencies for testing Signed-off-by: Dan McGee --- main/models.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/main/models.py b/main/models.py index af4466ff..ec2416f7 100644 --- a/main/models.py +++ b/main/models.py @@ -198,10 +198,8 @@ class Package(models.Model): # more than one package, see if we can't shrink it down # grab the first though in case we fail pkg = pkgs[0] - if self.repo.testing: - pkgs = pkgs.filter(repo__testing=True) - else: - pkgs = pkgs.filter(repo__testing=False) + # prevents yet more DB queries, these lists should be short + pkgs = [p for p in pkgs if p.repo.testing == self.repo.testing] if len(pkgs) > 0: pkg = pkgs[0] deps.append({'dep': dep, 'pkg': pkg}) -- cgit v1.2.3-55-g3dc8