From e6f3e5aa982b3628603842438bb649c927860dd0 Mon Sep 17 00:00:00 2001 From: Jelle van der Waa Date: Mon, 1 May 2017 22:38:23 +0200 Subject: devel.reports: remove unused arguments Signed-off-by: Jelle van der Waa --- devel/reports.py | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/devel/reports.py b/devel/reports.py index 66fbd627..dba982a9 100644 --- a/devel/reports.py +++ b/devel/reports.py @@ -21,19 +21,19 @@ class DeveloperReport(object): self.personal = personal -def old(packages, username): +def old(packages): cutoff = now() - timedelta(days=365 * 2) return packages.filter( build_date__lt=cutoff).order_by('build_date') -def outofdate(packages, username): +def outofdate(packages): cutoff = now() - timedelta(days=30) return packages.filter( flag_date__lt=cutoff).order_by('flag_date') -def big(packages, username): +def big(packages): cutoff = 50 * 1024 * 1024 packages = packages.filter( compressed_size__gte=cutoff).order_by('-compressed_size') @@ -46,7 +46,7 @@ def big(packages, username): return packages -def badcompression(packages, username): +def badcompression(packages): cutoff = 0.90 * F('installed_size') packages = packages.filter(compressed_size__gt=25*1024, installed_size__gt=25*1024, @@ -95,7 +95,7 @@ def uncompressed_info(packages, username): return packages.filter(id__in=set(bad_files)) -def unneeded_orphans(packages, username): +def unneeded_orphans(packages): owned = PackageRelation.objects.all().values('pkgbase') required = Depend.objects.all().values('name') # The two separate calls to exclude is required to do the right thing @@ -103,7 +103,7 @@ def unneeded_orphans(packages, username): pkgname__in=required) -def mismatched_signature(packages, username): +def mismatched_signature(packages): filtered = [] packages = packages.select_related( 'arch', 'repo', 'packager').filter(signature_bytes__isnull=False) @@ -127,7 +127,7 @@ def mismatched_signature(packages, username): return filtered -def signature_time(packages, username): +def signature_time(packages): cutoff = timedelta(hours=24) filtered = [] packages = packages.select_related( -- cgit v1.2.3-55-g3dc8 From a862e9fc66bee5cb9ff07b62a604d052d51e8265 Mon Sep 17 00:00:00 2001 From: Jelle van der Waa Date: Mon, 1 May 2017 22:38:45 +0200 Subject: devel.reports: remove unused imports Signed-off-by: Jelle van der Waa --- devel/reports.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/devel/reports.py b/devel/reports.py index dba982a9..b754b264 100644 --- a/devel/reports.py +++ b/devel/reports.py @@ -5,7 +5,7 @@ from django.db.models import F from django.template.defaultfilters import filesizeformat from django.utils.timezone import now -from .models import DeveloperKey, UserProfile +from .models import DeveloperKey from main.models import PackageFile from packages.models import PackageRelation, Depend -- cgit v1.2.3-55-g3dc8 From d8c7ee4f4d27e542b182bdc13cd38b335c638cb4 Mon Sep 17 00:00:00 2001 From: Jelle van der Waa Date: Mon, 1 May 2017 22:39:34 +0200 Subject: pgp_import: remove unused import Signed-off-by: Jelle van der Waa --- devel/management/commands/pgp_import.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/devel/management/commands/pgp_import.py b/devel/management/commands/pgp_import.py index 7a124f77..8eb06d50 100644 --- a/devel/management/commands/pgp_import.py +++ b/devel/management/commands/pgp_import.py @@ -7,7 +7,7 @@ Import keys and signatures from a given GPG keyring. Usage: ./manage.py pgp_import """ -from collections import namedtuple, OrderedDict +from collections import OrderedDict from datetime import datetime import logging from pytz import utc -- cgit v1.2.3-55-g3dc8 From a3e740aace064dda86aa5989047133284f8b0ba9 Mon Sep 17 00:00:00 2001 From: Jelle van der Waa Date: Mon, 1 May 2017 22:43:13 +0200 Subject: devel.forms: remove unused variable val Signed-off-by: Jelle van der Waa --- devel/forms.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/devel/forms.py b/devel/forms.py index e2b1a7a2..cd50eb50 100644 --- a/devel/forms.py +++ b/devel/forms.py @@ -59,7 +59,7 @@ class NewUserForm(forms.ModelForm): 'alias', 'public_email') for key in keys: self.fields[key] = old[key] - for key, val in old.items(): + for key, _ in old.items(): if key not in keys: self.fields[key] = old[key] -- cgit v1.2.3-55-g3dc8 From c38db1a8ea3b894af783bef45e73b8cdf1638f15 Mon Sep 17 00:00:00 2001 From: Jelle van der Waa Date: Mon, 1 May 2017 22:44:31 +0200 Subject: rematch_developers: fix logging not lazy Signed-off-by: Jelle van der Waa --- devel/management/commands/rematch_developers.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/devel/management/commands/rematch_developers.py b/devel/management/commands/rematch_developers.py index bbb43df0..8636002a 100644 --- a/devel/management/commands/rematch_developers.py +++ b/devel/management/commands/rematch_developers.py @@ -59,7 +59,7 @@ def match_packager(finder): user = finder.find(packager) if user: mapping[packager] = user - logger.debug(" found user %s" % user.username) + logger.debug(" found user %s", user.username) matched_count += 1 for packager_str, user in mapping.items(): @@ -85,7 +85,7 @@ def match_flagrequest(finder): user = finder.find_by_email(user_email) if user: mapping[user_email] = user - logger.debug(" found user %s" % user.username) + logger.debug(" found user %s", user.username) matched_count += 1 for user_email, user in mapping.items(): -- cgit v1.2.3-55-g3dc8