path: root/todolists
diff options
authorDan McGee <>2012-04-18 15:05:43 -0500
committerDan McGee <>2012-05-02 09:37:46 -0500
commitbadc535aeb1d310a9b8aa59aade07045e6eae653 (patch)
treeaf644de8b034d45ba296ab39da93b359312a38ca /todolists
parentf3e0adcb2fc9a26e2ad9337a47550a37590074d9 (diff)
Ensure order_by default value is cleared when using distinct()
Otherwise the queryset returns nonsensical results. I find the design of this less than obvious but so be it; we can ensure the results work regardless of a default ordering on the model. Signed-off-by: Dan McGee <>
Diffstat (limited to 'todolists')
1 files changed, 2 insertions, 2 deletions
diff --git a/todolists/ b/todolists/
index e5cc0823..70209b6d 100644
--- a/todolists/
+++ b/todolists/
@@ -49,8 +49,8 @@ def flag(request, list_id, pkg_id):
def view(request, list_id):
todolist = get_object_or_404(Todolist, id=list_id)
- svn_roots = Repo.objects.order_by().values_list(
- 'svn_root', flat=True).distinct()
+ svn_roots = Repo.objects.values_list(
+ 'svn_root', flat=True).order_by().distinct()
# we don't hold onto the result, but the objects are the same here,
# so accessing maintainers in the template is now cheap
attach_maintainers(tp.pkg for tp in todolist.packages)