summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAngel Velásquez <angvp@archlinux.org>2017-05-01 18:02:57 -0400
committerGitHub <noreply@github.com>2017-05-01 18:02:57 -0400
commit1d8dd5079526b2855391fb6c6408e474568f28f0 (patch)
tree8a774f8caa1fe925391c90fde73508fcb187f5f3
parentec76d3c1440e4320cd1c128ac701d49d5c095369 (diff)
parentc38db1a8ea3b894af783bef45e73b8cdf1638f15 (diff)
downloadarchweb-1d8dd5079526b2855391fb6c6408e474568f28f0.tar.gz
archweb-1d8dd5079526b2855391fb6c6408e474568f28f0.zip
Merge pull request #15 from jelly/pylint
Fix a couple of pylint warnings
-rw-r--r--devel/forms.py2
-rw-r--r--devel/management/commands/pgp_import.py2
-rw-r--r--devel/management/commands/rematch_developers.py4
-rw-r--r--devel/reports.py16
4 files changed, 12 insertions, 12 deletions
diff --git a/devel/forms.py b/devel/forms.py
index e2b1a7a2..cd50eb50 100644
--- a/devel/forms.py
+++ b/devel/forms.py
@@ -59,7 +59,7 @@ class NewUserForm(forms.ModelForm):
'alias', 'public_email')
for key in keys:
self.fields[key] = old[key]
- for key, val in old.items():
+ for key, _ in old.items():
if key not in keys:
self.fields[key] = old[key]
diff --git a/devel/management/commands/pgp_import.py b/devel/management/commands/pgp_import.py
index 7a124f77..8eb06d50 100644
--- a/devel/management/commands/pgp_import.py
+++ b/devel/management/commands/pgp_import.py
@@ -7,7 +7,7 @@ Import keys and signatures from a given GPG keyring.
Usage: ./manage.py pgp_import <keyring_path>
"""
-from collections import namedtuple, OrderedDict
+from collections import OrderedDict
from datetime import datetime
import logging
from pytz import utc
diff --git a/devel/management/commands/rematch_developers.py b/devel/management/commands/rematch_developers.py
index bbb43df0..8636002a 100644
--- a/devel/management/commands/rematch_developers.py
+++ b/devel/management/commands/rematch_developers.py
@@ -59,7 +59,7 @@ def match_packager(finder):
user = finder.find(packager)
if user:
mapping[packager] = user
- logger.debug(" found user %s" % user.username)
+ logger.debug(" found user %s", user.username)
matched_count += 1
for packager_str, user in mapping.items():
@@ -85,7 +85,7 @@ def match_flagrequest(finder):
user = finder.find_by_email(user_email)
if user:
mapping[user_email] = user
- logger.debug(" found user %s" % user.username)
+ logger.debug(" found user %s", user.username)
matched_count += 1
for user_email, user in mapping.items():
diff --git a/devel/reports.py b/devel/reports.py
index 66fbd627..b754b264 100644
--- a/devel/reports.py
+++ b/devel/reports.py
@@ -5,7 +5,7 @@ from django.db.models import F
from django.template.defaultfilters import filesizeformat
from django.utils.timezone import now
-from .models import DeveloperKey, UserProfile
+from .models import DeveloperKey
from main.models import PackageFile
from packages.models import PackageRelation, Depend
@@ -21,19 +21,19 @@ class DeveloperReport(object):
self.personal = personal
-def old(packages, username):
+def old(packages):
cutoff = now() - timedelta(days=365 * 2)
return packages.filter(
build_date__lt=cutoff).order_by('build_date')
-def outofdate(packages, username):
+def outofdate(packages):
cutoff = now() - timedelta(days=30)
return packages.filter(
flag_date__lt=cutoff).order_by('flag_date')
-def big(packages, username):
+def big(packages):
cutoff = 50 * 1024 * 1024
packages = packages.filter(
compressed_size__gte=cutoff).order_by('-compressed_size')
@@ -46,7 +46,7 @@ def big(packages, username):
return packages
-def badcompression(packages, username):
+def badcompression(packages):
cutoff = 0.90 * F('installed_size')
packages = packages.filter(compressed_size__gt=25*1024,
installed_size__gt=25*1024,
@@ -95,7 +95,7 @@ def uncompressed_info(packages, username):
return packages.filter(id__in=set(bad_files))
-def unneeded_orphans(packages, username):
+def unneeded_orphans(packages):
owned = PackageRelation.objects.all().values('pkgbase')
required = Depend.objects.all().values('name')
# The two separate calls to exclude is required to do the right thing
@@ -103,7 +103,7 @@ def unneeded_orphans(packages, username):
pkgname__in=required)
-def mismatched_signature(packages, username):
+def mismatched_signature(packages):
filtered = []
packages = packages.select_related(
'arch', 'repo', 'packager').filter(signature_bytes__isnull=False)
@@ -127,7 +127,7 @@ def mismatched_signature(packages, username):
return filtered
-def signature_time(packages, username):
+def signature_time(packages):
cutoff = timedelta(hours=24)
filtered = []
packages = packages.select_related(