summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan McGee <dan@archlinux.org>2013-02-09 16:43:40 -0600
committerDan McGee <dan@archlinux.org>2013-02-09 16:50:45 -0600
commit5566d43a7734f6bb2f48d5d511351da12ddc5cc1 (patch)
treed575d2c100a039100771fdc9ed056d33da23b6c3
parent8524a6057c4b99a620850494a22eb3d1f56bee68 (diff)
downloadarchweb-5566d43a7734f6bb2f48d5d511351da12ddc5cc1.tar.gz
archweb-5566d43a7734f6bb2f48d5d511351da12ddc5cc1.zip
Use 'update_fields' model.save() kwarg
This was added in Django 1.5 and allows saving only a subset of a model's fields. It makes sense in a few cases to utilize it. Signed-off-by: Dan McGee <dan@archlinux.org>
-rw-r--r--mirrors/management/commands/mirrorresolv.py2
-rw-r--r--packages/views/signoff.py2
-rw-r--r--releng/management/commands/syncisos.py2
-rw-r--r--todolists/views.py2
4 files changed, 4 insertions, 4 deletions
diff --git a/mirrors/management/commands/mirrorresolv.py b/mirrors/management/commands/mirrorresolv.py
index 0370f8ed..a6c2523e 100644
--- a/mirrors/management/commands/mirrorresolv.py
+++ b/mirrors/management/commands/mirrorresolv.py
@@ -53,7 +53,7 @@ def resolve_mirrors():
newvals = (mirrorurl.has_ipv4, mirrorurl.has_ipv6)
if newvals != oldvals:
logger.debug("values changed for %s", mirrorurl)
- mirrorurl.save(force_update=True)
+ mirrorurl.save(update_fields=('has_ipv4', 'has_ipv6'))
except socket.error, e:
logger.warn("error resolving %s: %s", mirrorurl.hostname, e)
diff --git a/packages/views/signoff.py b/packages/views/signoff.py
index 17f3095c..c37aa0fc 100644
--- a/packages/views/signoff.py
+++ b/packages/views/signoff.py
@@ -45,7 +45,7 @@ def signoff_package(request, name, repo, arch, revoke=False):
except Signoff.DoesNotExist:
raise Http404
signoff.revoked = now()
- signoff.save()
+ signoff.save(update_fields=('revoked',))
created = False
else:
# ensure we should even be accepting signoffs
diff --git a/releng/management/commands/syncisos.py b/releng/management/commands/syncisos.py
index 223c771b..c9f61964 100644
--- a/releng/management/commands/syncisos.py
+++ b/releng/management/commands/syncisos.py
@@ -53,7 +53,7 @@ class Command(BaseCommand):
if not existing.active:
existing.active = True
existing.removed = None
- existing.save()
+ existing.save(update_fields=('active', 'removed'))
# and then mark all other names as no longer active
Iso.objects.filter(active=True).exclude(name__in=active_isos).update(
active=False, removed=now())
diff --git a/todolists/views.py b/todolists/views.py
index f333728a..9935987b 100644
--- a/todolists/views.py
+++ b/todolists/views.py
@@ -47,7 +47,7 @@ def flag(request, slug, pkg_id):
else:
tlpkg.status = TodolistPackage.INCOMPLETE
tlpkg.user = request.user
- tlpkg.save()
+ tlpkg.save(update_fields=('status', 'user', 'last_modified'))
if request.is_ajax():
data = {
'status': tlpkg.get_status_display(),